-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial German language set #11017
base: dev
Are you sure you want to change the base?
Add initial German language set #11017
Conversation
@aiAdrian if you find some time, your german knowledge would be appreciated for review 😄 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #11017 +/- ##
==========================================
- Coverage 81.49% 80.70% -0.79%
==========================================
Files 1100 1098 -2
Lines 110826 111912 +1086
Branches 744 745 +1
==========================================
+ Hits 90315 90319 +4
- Misses 20468 21550 +1082
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you for your interest in the project and your contribution. The CI “check commits” fails for two reasons. The naming of the commits does not follow convention and the DCO is missing. Both are documented here. If you need any help or explanation, please don't hesitate to ask (here or on matrix). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Danke!
Minor typos, but otherwise it seems nice :) (but I don’t use user interfaces in German, so I might have missed some details).
At least we got rid of the fabulous „Infrastrukturverlag“
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My german is very scholar (but especially rusty), and might be less accurate for professional use ; feel free to ignore if you feel better to
Nochmals vielen Dank ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me !
This commit introduces the basic functionality to select German as a language and some keys (though still incomplete) for this language. This is supposed to be a base for subsequent additions in German.
front: confirm review translation suggestions Co-authored-by: Louis Greiner <[email protected]> Co-authored-by: Tristram Gräbener <[email protected]> Signed-off-by: Till-André Diegeler <[email protected]>
0f80d1e
to
b125a98
Compare
This commit introduces the basic functionality to select German as a language and some keys (though still vastly incomplete) for this language. This is supposed to be a base for subsequent additions in German.