Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial German language set #11017

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

ti-diegeler
Copy link

@ti-diegeler ti-diegeler commented Mar 3, 2025

This commit introduces the basic functionality to select German as a language and some keys (though still vastly incomplete) for this language. This is supposed to be a base for subsequent additions in German.

@ti-diegeler ti-diegeler requested a review from a team as a code owner March 3, 2025 20:34
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Mar 3, 2025
@louisgreiner
Copy link
Contributor

@aiAdrian if you find some time, your german knowledge would be appreciated for review 😄

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (afe570c) to head (0f80d1e).
Report is 38 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11017      +/-   ##
==========================================
- Coverage   81.49%   80.70%   -0.79%     
==========================================
  Files        1100     1098       -2     
  Lines      110826   111912    +1086     
  Branches      744      745       +1     
==========================================
+ Hits        90315    90319       +4     
- Misses      20468    21550    +1082     
  Partials       43       43              
Flag Coverage Δ
editoast 72.40% <ø> (+0.07%) ⬆️
front 89.93% <100.00%> (-0.05%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (-0.45%) ⬇️
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster
Copy link
Contributor

Thank you for your interest in the project and your contribution. The CI “check commits” fails for two reasons. The naming of the commits does not follow convention and the DCO is missing. Both are documented here.

If you need any help or explanation, please don't hesitate to ask (here or on matrix).

Copy link
Contributor

@Tristramg Tristramg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke!

Minor typos, but otherwise it seems nice :) (but I don’t use user interfaces in German, so I might have missed some details).

At least we got rid of the fabulous „Infrastrukturverlag“

Copy link
Contributor

@louisgreiner louisgreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My german is very scholar (but especially rusty), and might be less accurate for professional use ; feel free to ignore if you feel better to
Nochmals vielen Dank ;-)

Copy link
Contributor

@louisgreiner louisgreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

ti-diegeler and others added 3 commits March 9, 2025 13:08
This commit introduces the basic functionality to select German as a language and some keys (though still incomplete) for this language. This is supposed to be a base for subsequent additions in German.
front: confirm review translation suggestions

Co-authored-by: Louis Greiner <[email protected]>
Co-authored-by: Tristram Gräbener <[email protected]>
Signed-off-by: Till-André Diegeler <[email protected]>
@ti-diegeler ti-diegeler force-pushed the lang/german_initialization branch from 0f80d1e to b125a98 Compare March 9, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants