Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fixing 3 points of #2530 #2532

Merged
merged 1 commit into from
Dec 8, 2022
Merged

front: fixing 3 points of #2530 #2532

merged 1 commit into from
Dec 8, 2022

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Dec 8, 2022

See ticket #2530 :

  • les marqueurs départ/arrivée clignotent quand on bouge la souris sur une voie avec l'autre marqueur, c'est bizarre
  • la typo de la popup a changé, maplibre-gl.css impose la sienne, c'est chelou de leur part de pas laisser l'héritage ? Du co
  • il semble susbsister du debug dans OSRDSimulation/Map.tsx

@sim51 sim51 requested a review from a team December 8, 2022 08:39
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #2532 (211175a) into dev (401d5ba) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev    #2532   +/-   ##
=========================================
  Coverage     37.62%   37.63%           
  Complexity     1661     1661           
=========================================
  Files           551      551           
  Lines         16805    16803    -2     
  Branches       2351     2350    -1     
=========================================
  Hits           6323     6323           
+ Misses        10112    10110    -2     
  Partials        370      370           
Flag Coverage Δ
front 4.29% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/OSRDConfMap/RenderItineraryMarkers.tsx 0.00% <0.00%> (ø)
...src/applications/osrd/views/OSRDSimulation/Map.tsx 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sim51 sim51 force-pushed the bsi/following-maplibre branch from f8b67a4 to 211175a Compare December 8, 2022 08:56
@jacomyal jacomyal closed this Dec 8, 2022
@jacomyal jacomyal reopened this Dec 8, 2022
@sim51 sim51 merged commit 86f7651 into dev Dec 8, 2022
@sim51 sim51 deleted the bsi/following-maplibre branch December 8, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants