Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: enhance error logging #4815

Merged
merged 2 commits into from
Aug 22, 2023
Merged

editoast: enhance error logging #4815

merged 2 commits into from
Aug 22, 2023

Conversation

leovalais
Copy link
Contributor

Makes it easier to spot where an error originates just by looking at the logs (e.g.: DieselError)

@leovalais leovalais added the area:editoast Work on Editoast Service label Aug 14, 2023
@leovalais leovalais requested a review from a team as a code owner August 14, 2023 16:20
@leovalais leovalais force-pushed the lva/logging-improvements branch from ffd835d to b1fa13a Compare August 14, 2023 16:51
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #4815 (2394306) into dev (13e1ab5) will increase coverage by 0.00%.
Report is 9 commits behind head on dev.
The diff coverage is 40.90%.

@@            Coverage Diff            @@
##                dev    #4815   +/-   ##
=========================================
  Coverage     21.80%   21.81%           
  Complexity     2248     2248           
=========================================
  Files           861      861           
  Lines         90299    90321   +22     
  Branches       2284     2284           
=========================================
+ Hits          19693    19703   +10     
- Misses        69345    69357   +12     
  Partials       1261     1261           
Flag Coverage Δ
editoast 70.95% <40.90%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
editoast/src/client/mod.rs 100.00% <ø> (ø)
editoast/src/main.rs 9.34% <0.00%> (-0.21%) ⬇️
editoast/src/error.rs 26.66% <25.00%> (+1.66%) ⬆️
editoast/src/core/mod.rs 44.68% <57.14%> (+2.18%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leovalais leovalais added this pull request to the merge queue Aug 22, 2023
@leovalais leovalais removed this pull request from the merge queue due to a manual request Aug 22, 2023
@leovalais leovalais force-pushed the lva/logging-improvements branch from b1fa13a to 8c80d80 Compare August 22, 2023 14:33
@leovalais leovalais enabled auto-merge August 22, 2023 15:03
@leovalais leovalais added this pull request to the merge queue Aug 22, 2023
Merged via the queue into dev with commit 8adef5b Aug 22, 2023
@leovalais leovalais deleted the lva/logging-improvements branch August 22, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants