Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new props to specify the position of value (right or left) in the input #4962

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Add new props to specify the position of value (right or left) in the input #4962

merged 2 commits into from
Sep 11, 2023

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Sep 4, 2023

No description provided.

@kmer2016
Copy link
Contributor Author

kmer2016 commented Sep 4, 2023

Merge #4938 before

@kmer2016 kmer2016 marked this pull request as ready for review September 4, 2023 15:51
@kmer2016 kmer2016 requested a review from a team as a code owner September 4, 2023 15:51
@kmer2016 kmer2016 marked this pull request as draft September 4, 2023 15:52
@kmer2016 kmer2016 self-assigned this Sep 4, 2023
@kmer2016 kmer2016 changed the title Cnh/add prop to manage position of text on inputs Add new props to specify the position of value (right or left) in the input Sep 4, 2023
Uriel-Sautron
Uriel-Sautron approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !!! LGTM !!!

@kmer2016 kmer2016 mentioned this pull request Sep 11, 2023
Merged
@kmer2016 kmer2016 force-pushed the cnh/add-prop-to-manage-position-of-text-on-inputs branch from 8b6c30d to c23570c Compare September 11, 2023 10:30
@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #4962 (c88c746) into dev (3e1a8da) will increase coverage by 0.08%.
Report is 1 commits behind head on dev.
The diff coverage is 7.69%.

@@             Coverage Diff              @@
##                dev    #4962      +/-   ##
============================================
+ Coverage     22.78%   22.87%   +0.08%     
  Complexity     2462     2462              
============================================
  Files           857      849       -8     
  Lines         90489    90085     -404     
  Branches       2457     2449       -8     
============================================
- Hits          20619    20606      -13     
+ Misses        68524    68141     -383     
+ Partials       1346     1338       -8
Flag Coverage Δ
front 9.95% <7.69%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
front/src/common/BootstrapSNCF/InputGroupSNCF.tsx 0.00% <0.00%> (ø)
.../modules/allowances/components/STDCMAllowances.tsx 0.00% <0.00%> (ø)
front/src/common/BootstrapSNCF/InputSNCF.tsx 25.00% <25.00%> (+0.14%) ⬆️

... and 36 files with indirect coverage changes

@kmer2016 kmer2016 force-pushed the cnh/add-prop-to-manage-position-of-text-on-inputs branch from c23570c to c88c746 Compare September 11, 2023 10:34
@kmer2016 kmer2016 marked this pull request as ready for review September 11, 2023 13:12
@kmer2016 kmer2016 added this pull request to the merge queue Sep 11, 2023
Merged via the queue into dev with commit a5fad2f Sep 11, 2023
@kmer2016 kmer2016 deleted the cnh/add-prop-to-manage-position-of-text-on-inputs branch September 11, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Math-R Math-R Math-R approved these changes

@Uriel-Sautron Uriel-Sautron Uriel-Sautron approved these changes

@nicolaswurtz nicolaswurtz Awaiting requested review from nicolaswurtz

Assignees

@kmer2016 kmer2016

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmer2016 @Math-R @Uriel-Sautron