Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add placeholders in stdcm allowances inputs #5552

Merged
merged 1 commit into from
Nov 7, 2023
Merged

front: add placeholders in stdcm allowances inputs #5552

merged 1 commit into from
Nov 7, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 31, 2023 •
edited
Loading

closes #5549

image

@clarani clarani requested review from a team as code owners October 31, 2023 17:55
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #5552 (c3c30d5) into dev (46f8c64) will increase coverage by 0.14%.
Report is 12 commits behind head on dev.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##                dev    #5552      +/-   ##
============================================
+ Coverage     19.48%   19.63%   +0.14%     
  Complexity     2322     2322              
============================================
  Files           878      879       +1     
  Lines        105495   105492       -3     
  Branches       2544     2566      +22     
============================================
+ Hits          20560    20712     +152     
+ Misses        83454    83277     -177     
- Partials       1481     1503      +22
Flag Coverage Δ
front 8.38% <40.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ront/src/applications/operationalStudies/consts.ts 78.11% <100.00%> (ø)
front/src/reducers/osrdconf/index.ts 33.14% <100.00%> (ø)
front/src/reducers/osrdconf2/common/index.ts 81.29% <100.00%> (ø)
...t/src/applications/stdcm/views/OSRDStdcmConfig.tsx 0.00% <0.00%> (ø)
front/src/utils/strings.ts 49.12% <75.00%> (+4.22%) ⬆️
...les/stdcmAllowances/components/StdcmAllowances.tsx 0.00% <0.00%> (ø)

... and 24 files with indirect coverage changes

Khoyo
Khoyo approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the Core change

@clarani clarani force-pushed the cni-5549-placeholders-in-stdcm branch from 5445146 to f8a4768 Compare November 2, 2023 11:34
@clarani clarani requested a review from eckter as a code owner November 2, 2023 11:34
@clarani clarani marked this pull request as draft November 2, 2023 11:34
@clarani clarani force-pushed the cni-5549-placeholders-in-stdcm branch from f8a4768 to ee205fc Compare November 6, 2023 13:28
@clarani clarani removed the request for review from a team November 6, 2023 13:28
@clarani clarani marked this pull request as ready for review November 6, 2023 13:28
@clarani clarani force-pushed the cni-5549-placeholders-in-stdcm branch from ee205fc to 3ca6e8f Compare November 6, 2023 13:40
SarahBellaha
SarahBellaha approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kmer2016
Copy link
Contributor

kmer2016 commented Nov 7, 2023

LGTM ! :)

@clarani clarani force-pushed the cni-5549-placeholders-in-stdcm branch from 3ca6e8f to c3c30d5 Compare November 7, 2023 15:14
@clarani
Copy link
Contributor Author

clarani commented Nov 7, 2023

Viewed with Nicolas and Thibaut, we removed the placeholders '...'

@clarani clarani enabled auto-merge November 7, 2023 15:15
@clarani clarani added this pull request to the merge queue Nov 7, 2023
Merged via the queue into dev with commit c1679bd Nov 7, 2023
@clarani clarani deleted the cni-5549-placeholders-in-stdcm branch November 7, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khoyo Khoyo Khoyo approved these changes

@eckter eckter eckter approved these changes

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

@SarahBellaha SarahBellaha SarahBellaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: add placeholders to stdcm inputs
6 participants
@clarani @kmer2016 @Khoyo @eckter @nicolaswurtz @SarahBellaha