front: add placeholders in stdcm allowances inputs

front/src/applications/operationalStudies/consts.ts

@@ -191,8 +191,8 @@ export interface OsrdConfState {
   destinationDate?: string;
   destinationTime?: string;
   featureInfoClick: { displayPopup: boolean; feature?: Feature; coordinates?: number[] };
-  gridMarginBefore: number;
-  gridMarginAfter: number;
+  gridMarginBefore?: number;
+  gridMarginAfter?: number;
   trainScheduleIDsToModify: number[];
 }
 

front/src/applications/stdcm/views/OSRDStdcmConfig.tsx

@@ -18,7 +18,7 @@ import {
 import { getSelectedTrain } from 'reducers/osrdsimulation/selectors';
 import { RollingStockSelector } from 'modules/rollingStock/components/RollingStockSelector';
 import { osrdEditoastApi } from 'common/api/osrdEditoastApi';
-import STDCMAllowances from 'modules/stdcmAllowances/components/STDCMAllowances';
+import StdcmAllowances from 'modules/stdcmAllowances/components/StdcmAllowances';
 import { OsrdStdcmConfState } from 'applications/operationalStudies/consts';
 import OSRDStdcmResults from './OSRDStdcmResults';
 import RunningTime from '../components/RunningTime';
@@ -97,7 +97,7 @@ export default function OSRDConfig({
               <SpeedLimitByTagSelector condensed />
               <Itinerary />
               <RunningTime />
-              <STDCMAllowances />
+              <StdcmAllowances />
               <div className="osrd-config-stdcm-apply">
                 {/* TODO: use RTK request status */}
                 <button

front/src/modules/stdcmAllowances/components/STDCMAllowances.tsx → front/src/modules/stdcmAllowances/components/StdcmAllowances.tsx

@@ -18,9 +18,10 @@ import {
 } from 'reducers/osrdconf';
 import { StandardAllowance } from 'applications/operationalStudies/consts';
 import { AllowanceValue } from 'common/api/osrdEditoastApi';
-import { ALLOWANCE_UNITS_KEYS } from '../../../applications/stdcm/components/allowancesConsts';
+import { convertInputStringToNumber } from 'utils/strings';
+import { ALLOWANCE_UNITS_KEYS } from 'applications/stdcm/components/allowancesConsts';
 
-const STDCMAllowances = () => {
+const StdcmAllowances = () => {
   const { t } = useTranslation('allowances');
   const dispatch = useDispatch();
   const gridMarginBefore = useSelector(getGridMarginBefore);
@@ -54,9 +55,11 @@ const STDCMAllowances = () => {
         <InputSNCF
           id="standardAllowanceTypeGridMarginBefore"
           type="number"
-          value={gridMarginBefore}
+          value={gridMarginBefore || ''}
           unit={ALLOWANCE_UNITS_KEYS.time}
-          onChange={(e) => dispatch(updateGridMarginBefore(+e.target.value || 0))}
+          onChange={(e) =>
+            dispatch(updateGridMarginBefore(convertInputStringToNumber(e.target.value)))
+          }
           sm
           noMargin
           label={t('allowances:gridMarginBeforeAfter')}
@@ -67,9 +70,11 @@ const STDCMAllowances = () => {
         <InputSNCF
           id="standardAllowanceTypeGridMarginAfter"
           type="number"
-          value={gridMarginAfter}
+          value={gridMarginAfter || ''}
           unit={ALLOWANCE_UNITS_KEYS.time}
-          onChange={(e) => dispatch(updateGridMarginAfter(+e.target.value || 0))}
+          onChange={(e) =>
+            dispatch(updateGridMarginAfter(convertInputStringToNumber(e.target.value)))
+          }
           sm
           noMargin
           label=" "
@@ -82,8 +87,8 @@ const STDCMAllowances = () => {
           id="standardAllowanceTypeSelect"
           options={standardAllowanceTypes}
           handleType={onchangeType}
-          value={stdcmStandardAllowance?.value || 0}
-          type={stdcmStandardAllowance?.type || ''}
+          value={stdcmStandardAllowance?.value || ''}
+          type={stdcmStandardAllowance?.type || 'percentage'}
           orientation="right"
           typeValue="number"
           condensed
@@ -95,4 +100,4 @@ const STDCMAllowances = () => {
   );
 };
 
-export default STDCMAllowances;
+export default StdcmAllowances;

front/src/reducers/osrdconf/index.ts

@@ -104,8 +104,8 @@ const defaultCommonConf = {
   trainCompo: undefined,
   geojson: undefined,
   featureInfoClick: { displayPopup: false },
-  gridMarginBefore: 0,
-  gridMarginAfter: 0,
+  gridMarginBefore: undefined,
+  gridMarginAfter: undefined,
   trainScheduleIDsToModify: [],
 };
 

front/src/reducers/osrdconf2/common/index.ts

@@ -42,8 +42,8 @@ export const defaultCommonConf: OsrdConfState = {
   trainCompo: undefined,
   geojson: undefined,
   featureInfoClick: { displayPopup: false },
-  gridMarginBefore: 0,
-  gridMarginAfter: 0,
+  gridMarginBefore: undefined,
+  gridMarginAfter: undefined,
   trainScheduleIDsToModify: [],
 };
 

front/src/utils/strings.ts

@@ -47,3 +47,11 @@ export function geti18nKeyForNull(str: string | null): string {
 export function onlyDigit(str: string): string {
   return str.replace(/\D/g, '');
 }
+
+/**
+ * Given a string, return a number or undefined
+ * Useful for number input
+ */
+export function convertInputStringToNumber(str: string) {
+  return str !== '' && !Number.isNaN(str) ? +str : undefined;
+}