front: fix slopes editor form validation

[Wadjetz]

close #3479

• Make the field optional
• Graph modifications

No value

Zero

[codecov]

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (59b59b5) 19.45% compared to head (355f023) 19.45%.

Files	Patch %	Lines
...editor/components/LinearMetadata/FormComponent.tsx	0.00%	44 Missing ⚠️
front/src/common/IntervalsDataViz/IntervalItem.tsx	0.00%	19 Missing ⚠️
front/src/common/IntervalsDataViz/data.ts	0.00%	5 Missing ⚠️
front/src/types/editor.ts	0.00%	3 Missing ⚠️
...tions/editor/components/LinearMetadata/tooltip.tsx	0.00%	2 Missing ⚠️
...rc/applications/editor/tools/trackEdition/utils.ts	0.00%	2 Missing ⚠️
.../src/applications/editor/components/EditorForm.tsx	0.00%	1 Missing ⚠️
front/src/common/IntervalsDataViz/dataviz.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #5581      +/-   ##
============================================
- Coverage     19.45%   19.45%   -0.01%     
  Complexity     2326     2326              
============================================
  Files           907      907              
  Lines        106891   106911      +20     
  Branches       2579     2579              
============================================
  Hits          20795    20795              
- Misses        84584    84604      +20     
  Partials       1512     1512              

Flag	Coverage Δ
front	8.32% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SharglutDev]

Good job for the catch of this customOnChange !

Tested in local and everything seems to be working as expected. Tried also the forms for signals, detectors, switches, buffer stops and seen nothing strange.

[clarani]

LGTM ✅

[clarani]

We need to wait for Giuliana's point of view

[SharglutDev]

Take you for the changes. As checked with you, I think the curves and slopes values should be set to 0 as soon as we enter in the form.

Otherwise, I think it's strange that if the value is at 0, we see a - when hovering the interval editor. It might mislead the user as it's the same behavior than the undefined one.

Also you have some warnings in the file

[SharglutDev]

Thank you for the changes.
When I try to create a new tracksection, after drawing it and fill the required inputs, doesn't work. Its saying that curves and slopes are required properties even though gradiant and radius are set to 0 when entering the form.

On the other hand, the behavior when editing a track section with unspecified gradiants or radius is great, they are set automatically to 0, good job !

[SharglutDev]

Great job for this PR, thank you ! Tested and everything works as expected.

Left some naming comments. As I will be away the next 2 business days, I'll let @clarani resolve those so you are not blocked to merge the PR.

[clarani]

Thanks for this PR, almost there :)

[clarani]

LGTM and tested ! Nice job, thank you very much 🙏 🎉