-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add typescript rule for import types and eslint rule for import sorting #6550
Conversation
35a7a5b
to
9adf33b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6550 +/- ##
============================================
- Coverage 28.31% 28.27% -0.05%
Complexity 2177 2177
============================================
Files 1048 1048
Lines 129635 129976 +341
Branches 2577 2577
============================================
+ Hits 36710 36754 +44
- Misses 91436 91733 +297
Partials 1489 1489
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
94a1a8e
to
f655644
Compare
e4a40ab
to
08268a1
Compare
08268a1
to
bd86e2b
Compare
front/src/modules/trainschedule/components/ManageTrainSchedule/Allowances/helpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/d3Helpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/createSpaceTimeChart.ts
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/SpaceTimeChart.tsx
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/SpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceCurvesSlopes.tsx
Outdated
Show resolved
Hide resolved
78290ba
to
d5fcf1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, super nice work !!
close #6544
close #6782
verbatimModuleSyntax: true
in tsconfig.json to display type imports errors"@typescript-eslint/consistent-type-imports": "error"
in .eslintrc to trigger warnings for type impots when running eslint