-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix allowances do not reset when changing the path #6823
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6823 +/- ##
============================================
- Coverage 28.66% 28.65% -0.01%
- Complexity 2235 2238 +3
============================================
Files 1063 1063
Lines 131643 131669 +26
Branches 2647 2651 +4
============================================
- Hits 37731 37726 -5
- Misses 92391 92421 +30
- Partials 1521 1522 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When allowances & power restrictions are reset (if they existed before), should we either put the warning border on the tabs or display a warning toast to inform the user that he needs to set them again ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
39e138b
to
2708b5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
41f05bc
to
dfe8d14
Compare
closes #6820