Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix allowances do not reset when changing the path #6823

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Mar 7, 2024

closes #6820

@clarani clarani requested a review from a team as a code owner March 7, 2024 16:55
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 12.90323% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 28.65%. Comparing base (8433802) to head (dfe8d14).
Report is 3 commits behind head on dev.

Files Patch % Lines
front/src/common/Pathfinding/Pathfinding.tsx 11.11% 24 Missing ⚠️
...nents/RollingStockCard/RollingStockCardButtons.tsx 0.00% 2 Missing ⚠️
front/src/utils/array.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6823      +/-   ##
============================================
- Coverage     28.66%   28.65%   -0.01%     
- Complexity     2235     2238       +3     
============================================
  Files          1063     1063              
  Lines        131643   131669      +26     
  Branches       2647     2651       +4     
============================================
- Hits          37731    37726       -5     
- Misses        92391    92421      +30     
- Partials       1521     1522       +1     
Flag Coverage Δ
core 79.80% <ø> (+0.01%) ⬆️
editoast 74.87% <ø> (-0.07%) ⬇️
front 8.92% <12.90%> (+<0.01%) ⬆️
gateway 2.49% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When allowances & power restrictions are reset (if they existed before), should we either put the warning border on the tabs or display a warning toast to inform the user that he needs to set them again ?

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@clarani clarani force-pushed the cni-6820-fix-allowances branch 4 times, most recently from 39e138b to 2708b5e Compare March 13, 2024 16:07
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

@SharglutDev SharglutDev enabled auto-merge March 13, 2024 16:12
@SharglutDev SharglutDev disabled auto-merge March 14, 2024 08:17
@clarani clarani force-pushed the cni-6820-fix-allowances branch from 41f05bc to dfe8d14 Compare March 15, 2024 08:32
@clarani clarani added this pull request to the merge queue Mar 15, 2024
Merged via the queue into dev with commit 47de754 Mar 15, 2024
22 checks passed
@clarani clarani deleted the cni-6820-fix-allowances branch March 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowance ranges component spreads a bit too much
3 participants