-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: be able to select a via on the map even when pf failed #8677
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8677 +/- ##
============================================
- Coverage 36.88% 36.88% -0.01%
Complexity 2213 2213
============================================
Files 1253 1253
Lines 113838 113853 +15
Branches 3185 3185
============================================
+ Hits 41991 41993 +2
- Misses 69955 69968 +13
Partials 1892 1892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3a0538e
to
697cf94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me. Good job !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, left just one comment. Also it seems there is an issue with the trads in the editoast checks (maybe you can try a rebase).
front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/v2/ViasV2.tsx
Outdated
Show resolved
Hide resolved
697cf94
to
d58371c
Compare
d58371c
to
59f2560
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested
Closes #8497
Closes #8117