Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: be able to select a via on the map even when pf failed #8677

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

SarahBellaha
Copy link
Contributor

Closes #8497
Closes #8117

@SarahBellaha SarahBellaha requested a review from a team as a code owner September 2, 2024 06:25
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 36.88%. Comparing base (5038159) to head (59f2560).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
...ainSchedule/ManageTrainScheduleMap/RenderPopup.tsx 0.00% 15 Missing ⚠️
...rainSchedule/ManageTrainScheduleMap/setPointIti.ts 0.00% 9 Missing ⚠️
...omponents/Itinerary/DisplayItinerary/v2/ViasV2.tsx 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8677      +/-   ##
============================================
- Coverage     36.88%   36.88%   -0.01%     
  Complexity     2213     2213              
============================================
  Files          1253     1253              
  Lines        113838   113853      +15     
  Branches       3185     3185              
============================================
+ Hits          41991    41993       +2     
- Misses        69955    69968      +13     
  Partials       1892     1892              
Flag Coverage Δ
core 74.75% <ø> (ø)
editoast 71.94% <ø> (+<0.01%) ⬆️
front 14.94% <0.00%> (-0.01%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBellaha SarahBellaha force-pushed the sba/front/fix-via-selection-on-map branch 2 times, most recently from 3a0538e to 697cf94 Compare September 2, 2024 12:46
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me. Good job !

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, left just one comment. Also it seems there is an issue with the trads in the editoast checks (maybe you can try a rebase).

@SarahBellaha SarahBellaha force-pushed the sba/front/fix-via-selection-on-map branch from 697cf94 to d58371c Compare September 3, 2024 14:30
@SarahBellaha SarahBellaha force-pushed the sba/front/fix-via-selection-on-map branch from d58371c to 59f2560 Compare September 4, 2024 12:23
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@SarahBellaha SarahBellaha added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@SarahBellaha SarahBellaha added this pull request to the merge queue Sep 5, 2024
Merged via the queue into dev with commit 1b14ae3 Sep 5, 2024
22 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/fix-via-selection-on-map branch September 5, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants