front: replace some type assertions with non-null assertions #8822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/drop-type-asserts
branch
from
bad1972 to
407ab23
Compare
SharglutDev
approved these changes
Sep 12, 2024
front/src/applications/editor/tools/pointEdition/components/PointEditionLeftPanel.tsx
Outdated
Show resolved
Hide resolved
emersion
force-pushed
the
emr/drop-type-asserts
branch
from
407ab23 to
e9ac63b
Compare
emersion
force-pushed
the
emr/drop-type-asserts
branch
from
e9ac63b to
1386ba8
Compare
In general I prefer to avoid `as` type assertions as much as possible, because it makes the compiler ignore any type mismatch. The non-null assertion operator `!` is a bit better: if the types don't match, the compiler will error out. Use it in a bunch of places. See #8698 (comment)
emersion
force-pushed
the
emr/drop-type-asserts
branch
from
1386ba8 to
e6a7912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general I prefer to avoid
astype assertions as much as possible, because it makes the compiler ignore any type mismatch. The non-null assertion operator!is a bit better: if the types don't match, the compiler will error out.Use it in a bunch of places.
See #8698 (comment)