Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: refacto old e2e tests #9306

Merged
merged 11 commits into from
Nov 6, 2024
Merged

front: refacto old e2e tests #9306

merged 11 commits into from
Nov 6, 2024

Conversation

Maymanaf
Copy link
Contributor

@Maymanaf Maymanaf commented Oct 11, 2024 •
edited
Loading

Closes #9313

@Maymanaf Maymanaf mentioned this pull request Oct 11, 2024
Merged
1 task
@Maymanaf Maymanaf force-pushed the aba/e2e-refacto-old-tests branch 6 times, most recently from f8e6b09 to dbd8614 Compare October 16, 2024 10:18
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Oct 16, 2024
@Maymanaf Maymanaf force-pushed the aba/e2e-refacto-old-tests branch 2 times, most recently from c3a18c6 to f4417aa Compare October 17, 2024 20:29
@Maymanaf Maymanaf marked this pull request as ready for review October 17, 2024 20:35
@Maymanaf Maymanaf requested a review from a team as a code owner October 17, 2024 20:35
@Maymanaf Maymanaf force-pushed the aba/e2e-refacto-old-tests branch from f4417aa to a43ce7c Compare October 18, 2024 07:41
@github-actions github-actions bot removed the area:front Work on Standard OSRD Interface modules label Oct 18, 2024
@Maymanaf Maymanaf force-pushed the aba/e2e-refacto-old-tests branch from a43ce7c to e710897 Compare October 18, 2024 15:29
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Oct 18, 2024
@Maymanaf Maymanaf force-pushed the aba/e2e-refacto-old-tests branch 14 times, most recently from 85e4a4e to 6b02ebf Compare October 22, 2024 16:42
@Maymanaf
Copy link
Contributor Author

next time you will have to create a huge modification, can you please amend the description of the PR in order to help the reviewer?

It really help us to have a first view of what it is about

@Yohh The main ticket does cover the key changes made, but I agree it’s not clearly described in the PR. I’ll make sure to update the description next time if there are significant changes

Yohh
Yohh reviewed Oct 31, 2024
View reviewed changes
@Maymanaf Maymanaf force-pushed the aba/e2e-refacto-old-tests branch 4 times, most recently from c8948b2 to 9976a7d Compare November 4, 2024 13:11
@Maymanaf Maymanaf requested review from Uriel-Sautron and emersion and removed request for emersion November 5, 2024 09:26
@Synar
Copy link
Contributor

Synar commented Nov 5, 2024 •
edited
Loading

The tests work fine on my computer, on fedora running playwright through docker (just one flaky with a timeout : 004-scenario-management.spec.ts:58:7 › Validate the Scenario creation workflow › Update an existing scenario) (I only ran the chromium tests)

@Yohh
Copy link
Contributor

Yohh commented Nov 5, 2024

everything is ok with all containers launched, the problem occurs while using host-compose.sh without the front container.

Yohh
Yohh approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice work

Math-R
Math-R approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improve off the test suite ! @Yohh has already covered the different points ! LGTM !

Maymanaf added 11 commits November 6, 2024 11:01
@Maymanaf
front: refacto project setup and utils
f479500 
Signed-off-by: maymanaf <[email protected]>
@Maymanaf
front: refacto home page tests
576f887 
Signed-off-by: maymanaf <[email protected]>
@Maymanaf
front: refacto project management tests
aa76ed5 
Signed-off-by: maymanaf <[email protected]>
@Maymanaf
front: refacto study management tests
d919e6b 
Signed-off-by: maymanaf <[email protected]>
@Maymanaf
front: refacto scenario management tests
0ad2a2f 
Signed-off-by: maymanaf <[email protected]>
@Maymanaf
front: refacto operational studies test
d2d6ace 
Signed-off-by: maymanaf <[email protected]>
@Maymanaf
front: refacto op rolling stock tab tests
f1d6a83 
Signed-off-by: maymanaf <[email protected]>
@Maymanaf
front: refacto op route tab tests
25b3ca3 
Signed-off-by: maymanaf <[email protected]>
@Maymanaf
front: refacto train schedule tests
1109f48 
Signed-off-by: maymanaf <[email protected]>
@Maymanaf
front: refacto rolling stock editor tests
0d78204 
Signed-off-by: maymanaf <[email protected]>
@Maymanaf
front: refacto op tables tests
1273f3a 
Signed-off-by: maymanaf <[email protected]>
@Maymanaf Maymanaf force-pushed the aba/e2e-refacto-old-tests branch from bbbad9c to 1273f3a Compare November 6, 2024 10:04
@Maymanaf Maymanaf enabled auto-merge November 6, 2024 10:04
@Maymanaf Maymanaf added this pull request to the merge queue Nov 6, 2024
Merged via the queue into dev with commit cd3935d Nov 6, 2024
24 checks passed
@Maymanaf Maymanaf deleted the aba/e2e-refacto-old-tests branch November 6, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion left review comments

@Yohh Yohh Yohh approved these changes

@Math-R Math-R Math-R approved these changes

@Caracol3 Caracol3 Awaiting requested review from Caracol3

@clarani clarani Awaiting requested review from clarani

@Uriel-Sautron Uriel-Sautron Awaiting requested review from Uriel-Sautron

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: refacto old e2e tests
5 participants
@Maymanaf @Yohh @Synar @emersion @Math-R