front: fix decimals error for study budget

[Akctarus]

closes #8607

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.41%. Comparing base (95c1305) to head (268ae20).
Report is 56 commits behind head on dev.

Files with missing lines	Patch %	Lines
front/src/modules/study/utils.ts	0.00%	2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #9598      +/-   ##
============================================
- Coverage     42.57%   42.41%   -0.16%     
- Complexity     2271     2272       +1     
============================================
  Files          1311     1314       +3     
  Lines        105246   105821     +575     
  Branches       3296     3305       +9     
============================================
+ Hits          44810    44888      +78     
- Misses        58490    58980     +490     
- Partials       1946     1953       +7     

Flag	Coverage Δ
core	74.95% <ø> (-0.11%)	⬇️
editoast	73.22% <ø> (-0.48%)	⬇️
front	18.79% <0.00%> (-0.01%)	⬇️
gateway	2.18% <ø> (-0.32%)	⬇️
osrdyne	3.28% <ø> (+<0.01%)	⬆️
railjson_generator	87.49% <ø> (ø)
tests	86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[emersion]

This looks much better! I have one remaining question: we already have some validation logic in checkStudyFields(). I think it would make sense to have a single spot where all of the validation is performed, instead of having half of it in one place and the other somewhere else?

One approach would be to add an extra condition to checkStudyFields() and change the existing error message to "not an integer between 0 and $max". Another approach would be to return an error string (or translation key) from checkStudyFields() instead of a boolean.

[emersion]

Seems like there is a duplicate PR? #9663 seems identical.

[theocrsb]

LGTM and tested :)

[Akctarus]

Seems like there is a duplicate PR? #9663 seems identical.

#9663 is for project budget, this one is for study budget :)

[emersion]

My bad! LGTM :)