Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix decimals error for project budget #9663

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Nov 8, 2024

closes #9662

@Akctarus Akctarus requested a review from a team as a code owner November 8, 2024 17:18
@Akctarus Akctarus requested a review from emersion November 8, 2024 17:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.41%. Comparing base (f05eecf) to head (cc50c8a).
Report is 26 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/modules/project/utils.ts 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9663      +/-   ##
============================================
- Coverage     42.50%   42.41%   -0.09%     
  Complexity     2272     2272              
============================================
  Files          1312     1314       +2     
  Lines        105588   105822     +234     
  Branches       3304     3305       +1     
============================================
+ Hits          44881    44889       +8     
- Misses        58754    58980     +226     
  Partials       1953     1953              
Flag Coverage Δ
core 74.95% <ø> (-0.11%) ⬇️
editoast 73.22% <ø> (-0.51%) ⬇️
front 18.79% <0.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Akctarus Akctarus force-pushed the tmn/front/fix-project-budget-input branch from 003ddbe to cc50c8a Compare November 15, 2024 08:48
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@theocrsb theocrsb enabled auto-merge November 15, 2024 08:49
@theocrsb theocrsb added this pull request to the merge queue Nov 15, 2024
Merged via the queue into dev with commit 2cc9582 Nov 15, 2024
27 checks passed
@theocrsb theocrsb deleted the tmn/front/fix-project-budget-input branch November 15, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting float budget gives unreadable error in project
4 participants