-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display total length and running time in simulation tabs #9777
display total length and running time in simulation tabs #9777
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9777 +/- ##
==========================================
- Coverage 37.88% 37.80% -0.09%
==========================================
Files 992 994 +2
Lines 90966 91163 +197
Branches 1176 1176
==========================================
Hits 34463 34463
- Misses 56049 56246 +197
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
3a02905
to
9ce8c76
Compare
9603872
to
fa93850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, left a few comments
front/src/applications/stdcm/components/StdcmResults/StdcmSimulationNavigator.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/StdcmResults/StdcmSimulationNavigator.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/StdcmResults/StdcmSimulationNavigator.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job ! You can resolve the last comment when fixed and merge :)
…n of simulation Signed-off-by: nncluzu <[email protected]>
63bad33
to
ee34681
Compare
closes #9678