Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display total length and running time in simulation tabs #9777

Merged

Conversation

kmer2016
Copy link
Contributor

closes #9678

@kmer2016 kmer2016 requested a review from a team as a code owner November 19, 2024 09:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 6.25000% with 60 lines in your changes missing coverage. Please review.

Project coverage is 37.80%. Comparing base (b4a69f6) to head (ee34681).
Report is 26 commits behind head on dev.

Files with missing lines Patch % Lines
...mponents/StdcmResults/StdcmSimulationNavigator.tsx 0.00% 49 Missing ⚠️
front/src/utils/date.ts 26.66% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9777      +/-   ##
==========================================
- Coverage   37.88%   37.80%   -0.09%     
==========================================
  Files         992      994       +2     
  Lines       90966    91163     +197     
  Branches     1176     1176              
==========================================
  Hits        34463    34463              
- Misses      56049    56246     +197     
  Partials      454      454              
Flag Coverage Δ
editoast 72.98% <ø> (-0.38%) ⬇️
front 20.10% <6.25%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kmer2016 kmer2016 force-pushed the cnh/display-total-length-and-running-time-in-simulation-tabs branch from 3a02905 to 9ce8c76 Compare November 19, 2024 10:10
@theocrsb
Copy link
Contributor

Shouldn't the text be on one line?

mockup:
image

app:
image

@kmer2016
Copy link
Contributor Author

Shouldn't the text be on one line?

mockup: image

app: image

Good catch! It seems this issue was introduced during the rebase !

@theocrsb
Copy link
Contributor

I think a small 10px margin is missing
mockup:
image

app:
image

@kmer2016 kmer2016 force-pushed the cnh/display-total-length-and-running-time-in-simulation-tabs branch from 9603872 to fa93850 Compare November 20, 2024 09:14
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, left a few comments

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job ! You can resolve the last comment when fixed and merge :)

@kmer2016 kmer2016 force-pushed the cnh/display-total-length-and-running-time-in-simulation-tabs branch from 63bad33 to ee34681 Compare November 22, 2024 08:39
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 22, 2024
@kmer2016 kmer2016 enabled auto-merge November 22, 2024 08:39
@kmer2016 kmer2016 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into dev with commit 9579941 Nov 22, 2024
27 checks passed
@kmer2016 kmer2016 deleted the cnh/display-total-length-and-running-time-in-simulation-tabs branch November 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lmr: front: display total length and running time in simulation tabs
4 participants