editoast, front, core: remove gamma type #9887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre-Etienne Bougué <[email protected]>
github-actions
bot
added
area:railjson
bougue-pe
force-pushed
the
peb/editoast/rs_model_add_ertms
branch
from
952a63b to
1dbe992
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9887 +/- ##
==========================================
- Coverage 38.22% 38.18% -0.05%
==========================================
Files 995 997 +2
Lines 91893 92177 +284
Branches 1189 1192 +3
==========================================
+ Hits 35128 35195 +67
- Misses 56311 56526 +215
- Partials 454 456 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leovalais
approved these changes
Nov 28, 2024
Maymanaf
approved these changes
Nov 28, 2024
bougue-pe
force-pushed
the
peb/editoast/rs_model_add_ertms
branch
from
1dbe992 to
5f606d7
Compare
rename gamma to const_gamma to reflect its use: constant gamma braking coefficient used when NOT circulating under ETCS/ERTMS signaling system in m/s^2. Signed-off-by: Pierre-Etienne Bougué <[email protected]>
bougue-pe
force-pushed
the
peb/editoast/rs_model_add_ertms
branch
from
5f606d7 to
b75d773
Compare
bougue-pe
added a commit
to bougue-pe/pyOSRD
that referenced
this pull request
Nov 28, 2024
after OpenRailAssociation/osrd#9887 - [ ] To be merged once osrd's PR is merged.
1 task
Wadjetz
approved these changes
Nov 28, 2024
bougue-pe
requested review from
Math-R and
Caracol3
and removed request for
Math-R
bougue-pe
requested review from
emersion and
achrafmohye
and removed request for
Caracol3
Erashin
approved these changes
Nov 28, 2024
woshilapin
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
The PR seems good. However, I'm missing some understanding about why it's fine to remove some (possibly not really well-supported) functionality: why removing MAX? It'd be nice to at least explain in the PR description why it was there? Why we decided to remove it? Just put some tracing about this decision so "future us" understand why, at this point in time, we decided to remove MAX.
emersion
approved these changes
Nov 28, 2024
All use of braking is currently constant in code, and in database. So it is now explicit. Signed-off-by: Pierre-Etienne Bougué <[email protected]>
bougue-pe
commented
Nov 28, 2024
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope_sim/PhysicsRollingStock.java
Show resolved
Hide resolved
Erashin
approved these changes
Dec 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9708
Rename
gammatoconst_gammato reflect its use: constant gamma braking coefficient used when NOT circulating under ETCS/ERTMS signaling system in m/s^2.All rolling stock used are
CONST, front always providedCONST, thisMAXvariant was never used, and actually always constant in code use (and not sure if a max-check was missing in computeAcceleration)🔍 please review by commit.
To merge right after this: