Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable links section in node sidebar in standalone mode #210

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

emersion
Copy link
Collaborator

@emersion emersion commented Aug 5, 2024

This is SBB-specific.

@emersion emersion requested a review from aiAdrian as a code owner August 5, 2024 16:20
@emersion emersion changed the title fix: disable links section in node sidebar fix: disable links section in node sidebar in standalone mode Aug 5, 2024
@louisgreiner louisgreiner self-requested a review August 5, 2024 17:44
@aiAdrian
Copy link
Collaborator

aiAdrian commented Aug 6, 2024

I approved this. But we might have to refactor once the disableBackend approach. This changed might be an option which could only be used if the operation point is located in switzerland. => At the moment i don't have any idea how to resolve this issue in a more general manner.

@emersion emersion self-assigned this Aug 6, 2024
@emersion
Copy link
Collaborator Author

emersion commented Aug 6, 2024

That's a good point! We could add a separate knob to enable/disable SBB-specific features if we wanted to. Then from standalone mode one could do <sbb-root disable-sbb-features="true"> if they want to.

@aiAdrian
Copy link
Collaborator

aiAdrian commented Aug 6, 2024

@emersion : Do we need to track this point in a separate issue? Any suggestions are welcome.

@louisgreiner
Copy link
Collaborator

I opened a new issue to track this and work on it later

-> #216

@emersion emersion merged commit c86ba57 into main Aug 6, 2024
6 checks passed
@emersion emersion deleted the disable-backend-node-links branch August 6, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants