Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long email addresses cause incorrect formatting of the left sidebar change history - resolved #254

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Long email addresses cause incorrect formatting of the left sidebar change history - resolved #254

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1e30041
issue resolved
aiAdrian Aug 19, 2024
a52c8ed
Merge branch 'main' of https://github.com/SchweizerischeBundesbahnen/…
aiAdrian Aug 20, 2024
da0b9bc
comments removed
aiAdrian Aug 20, 2024
8676d49
Overworked - now the email address gets copied and the log service sh…
aiAdrian Aug 20, 2024
9c17b1a
Merge branch 'main' of https://github.com/SchweizerischeBundesbahnen/…
aiAdrian Aug 20, 2024
9fea47b
margin is not 0px - just 0
aiAdrian Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ant/variant-view/variant-history/version-entry-layout/version-entry-layout.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<div class="info-field title-field" *ngIf="getTitle(); let title">
{{ title }}
</div>
<div class="info-field title-field" *ngIf="getUserId(); let userId">
<div class="info-field title-field user-id" *ngIf="getUserId(); let userId">
{{ userId }}
</div>
<div class="info-field date-field">
Expand Down
19 changes: 19 additions & 0 deletions ...ant/variant-view/variant-history/version-entry-layout/version-entry-layout.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,22 @@
border: none;
}
}


.user-id {
width: 140px; /* Set the desired width */
overflow: auto; /* Hide overflowing content */
text-overflow: ellipsis; /* Display ellipsis (...) for overflow */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the input field doesn't show "asupersuperlongem..."but "asupersuperlongem", you might just comment that the email overflows, but doesn't display "..."

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have overworked the "UX concept" - now the email address gets copied and the log service shows a toast to inform you that the email address was copied. The copied function is as well active, when user clicks on the comments.

white-space: nowrap; /* Prevent text from wrapping */
user-select: text; /* Allow text selection */
}

.user-id {
-ms-overflow-style: none; /* for Internet Explorer, Edge */
scrollbar-width: none; /* for Firefox */
overflow-y: scroll;
}

.user-id {::-webkit-scrollbar {
display: none; /* for Chrome, Safari, and Opera */
}}