Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a toggle for docsy tabpanes so that it doesn't automatically add code #915

Merged
merged 5 commits into from
Jan 10, 2022

Conversation

titusfortner
Copy link
Member

This replaces #872

I figured out how to toggle instead of replace, this is a much easier way to do this.
@diemol I'm waiting to PR it to Docsy based on your feedback.

You can see examples of everything in the new style guide page I made.

@netlify
Copy link

netlify bot commented Jan 7, 2022

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: 9c49a55

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/61dca08d7bf7110007a1a9e7

😎 Browse the preview: https://deploy-preview-915--jovial-austin-42fe02.netlify.app

@titusfortner
Copy link
Member Author

Added a new commit to put a GitHub link at the bottom of a tab in auto-code-block mode

@titusfortner titusfortner mentioned this pull request Jan 9, 2022
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this, but there seems to be a conflic I would prefer you to fix it so we can merge. Thanks, @titusfortner!

@titusfortner
Copy link
Member Author

Ok, I rebased this, adding the other new content to the new Styles documentation page.
Also slightly better CSS than what I had before

@titusfortner titusfortner requested a review from diemol January 10, 2022 20:31
@diemol diemol merged commit af6a3b6 into SeleniumHQ:dev Jan 10, 2022
selenium-ci added a commit that referenced this pull request Jan 10, 2022
…y add code (#915) [deploy site]

* update alert shortcodes

* update style info and move it into its own page

* implement a toggle for docsy tabpanes so that it doesn't automatically use a code block

* implement a github reference for auto-code blocks

Co-authored-by: Diego Molina <[email protected]> af6a3b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants