Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example code #920

Merged
merged 11 commits into from
Jan 12, 2022
Merged

Example code #920

merged 11 commits into from
Jan 12, 2022

Conversation

titusfortner
Copy link
Member

This PR is several things:

  1. A new directory (/examples) to contain repos in Java, Ruby, .NET and Python for putting code examples
  2. A real-world example of what the shortcode in implement a toggle for docsy tabpanes so that it doesn't automatically add code #915 can do (this PR relies on that PR)
  3. A re-working of the Getting Started pages with easier to process code examples

Note the ability to mix between code and text in the tabs
Note the "See full example on GitHub" links (they are working, but we need to decide how we will keep them synchronized)
I added an implicit wait to first script because of stupid Google timing issues.

  • I don't know how to create a basic JS project or Kotlin project, so there is no repo and no links to those code snippets, and while I think they work, I'm not an expert
  • We can add a github action to run this code if we like this setup

This PR is going to need some rebasing still, but I need some feedback on it.

@netlify
Copy link

netlify bot commented Jan 9, 2022

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: cb5fcf0

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/61de9eb5e9ac2500074c9945

😎 Browse the preview: https://deploy-preview-920--jovial-austin-42fe02.netlify.app

@titusfortner
Copy link
Member Author

Ah, I started to make links to the browser specific functionality in open browser and only did it for Chrome. I'll fix that.

@titusfortner
Copy link
Member Author

This now includes #873 because the steps in the getting started guide don't make sense without those new links.
I incorporated all the newest updates from other users, and rebased against the translations.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @titusfortner!

@diemol diemol merged commit d22cd1c into dev Jan 12, 2022
@diemol diemol deleted the example_code branch January 12, 2022 09:31
selenium-ci added a commit that referenced this pull request Jan 12, 2022
* describe element actions

* create dotnet examples project

* create java examples project

* create python examples project

* create ruby examples project

* dotnet getting started code examples

* java getting started code examples

* python getting started code examples

* ruby getting started examples

* re-do the getting started section with code examples and new shortcode

Co-authored-by: Diego Molina <[email protected]> d22cd1c
@diemol diemol mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants