Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing linux dependencies after ubuntu-latest runner update #2647

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

giacomocusinato
Copy link
Collaborator

@giacomocusinato giacomocusinato commented Feb 27, 2025

Motivation

Ubuntu 24.04 is the new default version for Ubuntu latest runner actions/runner-images#10636

Ubuntu 24.04 no longer includes the following dependencies:

  • libx11-dev, libxkbfile-dev required by native-keymap
  • libsecret-1-dev required by keytar package.

Note that keytar is now deprecated and it's a dependency on both IDE2 and Theia eclipse-theia/theia#13593

Change description

Manually install missing dependencies in CI workflows only for Linux

Other information

Adopted in favour of #2649

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@giacomocusinato giacomocusinato changed the title Fix linux deps fix: add missing linux dependencies Feb 27, 2025
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Feb 28, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the steps are named "Install dependencies (Linux only)" and others "Install Dependencies (Ubuntu)". Either name is fine, but I think it would be better to be consistent across all the workflows.

@giacomocusinato giacomocusinato force-pushed the fix-linux-deps branch 2 times, most recently from d32178b to 9e8d2fc Compare February 28, 2025 08:54
@giacomocusinato giacomocusinato marked this pull request as ready for review February 28, 2025 08:54
Install `libx11-dev`, `libxkbfile-dev`, `libsecret-1-dev` libraries as the most recent update to ubuntu-latest does not include them
Signed-off-by: dankeboy36 <[email protected]>
@giacomocusinato giacomocusinato changed the title fix: add missing linux dependencies fix: add missing linux dependencies after ubuntu-latest runner update Feb 28, 2025
@giacomocusinato giacomocusinato merged commit 1712f9e into main Feb 28, 2025
23 checks passed
@giacomocusinato giacomocusinato deleted the fix-linux-deps branch February 28, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants