Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin ubuntu-22.04 runner for linux actions #2649

Closed
wants to merge 1 commit into from

Conversation

giacomocusinato
Copy link
Collaborator

@giacomocusinato giacomocusinato commented Feb 27, 2025

Motivation

Ubuntu 24.04 is the new default version for Ubuntu latest runner actions/runner-images#10636

Ubuntu 24.04 no longer includes the libsecret-1-dev dependency required by keytar on Linux.
keytar is now deprecated and it's a dependency on both IDE2 and Theia eclipse-theia/theia#13593

During the transition of getting away fromkeytar, we should use pin runner to ubuntu-22.04 to ensure libsecret-1-dev is present.

Change description

Other information

This might be a better solution then manually installing dependency on each task #2647

Any suggestion on which solution to adopt is appreciated

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@giacomocusinato giacomocusinato changed the title chore: pin ubuntu-22.04 for linux actions chore: pin ubuntu-22.04 runner for linux actions Feb 27, 2025
@giacomocusinato giacomocusinato added the topic: infrastructure Related to project infrastructure label Feb 27, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #2647 is the better solution. The reason being that this solution will stop working when GitHub removes the ubuntu-22.04 runner, whereas #2647 is a permanent fix.

The exception would be if we had some indication that the packages will eventually be added to the ubuntu-24.04 runner, and this is only intended to be a temporary workaround until that time. However, I haven't found anything to indicate that might happen (I did see a report here, but no response) and I think the ubuntu-24.04 runner is fairly mature at this point.

@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Feb 28, 2025
@giacomocusinato
Copy link
Collaborator Author

Thanks for the input @per1234.
I don't have a strong opinion on this, so I agree on keeping ubuntu-latest for better long term support.
Eventually if we move away from the keytar dependency we can remove the additional manual setup for Linux.

I'm closing this draft in favour of #2647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants