Cw 940 reduce impossible api calls to trocador #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarHatem28
requested changes
Feb 24, 2025
| ?? initialAmountByAssets(isFixedRateMode ? receiveCurrency : depositCurrency); | ||
|
|
||
| final validProvidersForAmount = _tradeAvailableProviders.where((provider) { | ||
| final limits = _providerLimits[provider]; |
There was a problem hiding this comment.
_providerLimits would still be empty on the first call of calculateBestRate, thus it will not fetch any best rate until the user enters an amount
let's better handle this, I believe calling calculateBestRate inside of loadLimits, should work.
but Note, that we should remove it from other places were they are called together, so we avoid repeated calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist