Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cw 940 reduce impossible api calls to trocador #2050

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cw 940 reduce impossible api calls to trocador #2050

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9261e45
skip Impossible API calls on exchange flow
Serhii-Borodenko Feb 24, 2025
35a8834
Merge branch 'main' into CW-940-Reduce-impossible-API-calls-to-Trocador
Serhii-Borodenko Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 66 additions & 18 deletions lib/view_model/exchange/exchange_view_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ abstract class ExchangeViewModelBase extends WalletChangeListenerViewModel with

final List<ExchangeProvider> _tradeAvailableProviders = [];

Map<ExchangeProvider, Limits> _providerLimits = {};

@observable
ObservableList<ExchangeProvider> selectedProviders;

Expand Down Expand Up @@ -422,9 +424,24 @@ abstract class ExchangeViewModelBase extends WalletChangeListenerViewModel with
return true;
}
Future<void> calculateBestRate() async {
final amount = double.tryParse(isFixedRateMode ? receiveAmount : depositAmount) ?? 1;
if (depositCurrency == receiveCurrency) {
bestRate = 0.0;
return;
}
final amount = double.tryParse(isFixedRateMode ? receiveAmount : depositAmount)
?? initialAmountByAssets(isFixedRateMode ? receiveCurrency : depositCurrency);

final validProvidersForAmount = _tradeAvailableProviders.where((provider) {
final limits = _providerLimits[provider];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_providerLimits would still be empty on the first call of calculateBestRate, thus it will not fetch any best rate until the user enters an amount
let's better handle this, I believe calling calculateBestRate inside of loadLimits, should work.
but Note, that we should remove it from other places were they are called together, so we avoid repeated calls


if (limits == null) return false;
if (limits.min != null && amount < limits.min!) return false;
if (limits.max != null && amount > limits.max!) return false;

return true;
}).toList();

final _providers = _tradeAvailableProviders
final _providers = validProvidersForAmount
.where((element) => !isFixedRateMode || element.supportsFixedRate)
.toList();

Expand Down Expand Up @@ -462,6 +479,10 @@ abstract class ExchangeViewModelBase extends WalletChangeListenerViewModel with

@action
Future<void> loadLimits() async {
if (depositCurrency == receiveCurrency) {
limitsState = LimitsLoadedSuccessfully(limits: Limits(min: 0, max: 0));
return;
};
if (selectedProviders.isEmpty) return;

limitsState = LimitsIsLoading();
Expand All @@ -473,23 +494,27 @@ abstract class ExchangeViewModelBase extends WalletChangeListenerViewModel with
double? highestMax = 0.0;

try {
final result = await Future.wait(
selectedProviders.where((provider) => providersForCurrentPair().contains(provider)).map(
(provider) => provider
.fetchLimits(
from: from,
to: to,
isFixedRateMode: isFixedRateMode,
)
.onError((error, stackTrace) => Limits(max: 0.0, min: double.maxFinite))
.timeout(
Duration(seconds: 7),
onTimeout: () => Limits(max: 0.0, min: double.maxFinite),
),
),
);
final futures = selectedProviders
.where((provider) => providersForCurrentPair().contains(provider))
.map((provider) async {
final limits = await provider
.fetchLimits(
from: from,
to: to,
isFixedRateMode: isFixedRateMode,
)
.onError((error, stackTrace) => Limits(max: 0.0, min: double.maxFinite))
.timeout(
Duration(seconds: 7),
onTimeout: () => Limits(max: 0.0, min: double.maxFinite),
);
return MapEntry(provider, limits);
}).toList();

result.forEach((tempLimits) {
final entries = await Future.wait(futures);
_providerLimits = Map.fromEntries(entries);

_providerLimits.values.forEach((tempLimits) {
if (lowestMin != null && (tempLimits.min ?? -1) < lowestMin!) {
lowestMin = tempLimits.min;
}
Expand Down Expand Up @@ -518,6 +543,12 @@ abstract class ExchangeViewModelBase extends WalletChangeListenerViewModel with

@action
Future<void> createTrade() async {
if (depositCurrency == receiveCurrency) {
tradeState = TradeIsCreatedFailure(
title: S.current.trade_not_created,
error: 'Can\'t exchange the same currency');
return;
}
if (isSendAllEnabled) {
await calculateDepositAllAmount();
final amount = double.tryParse(depositAmount);
Expand Down Expand Up @@ -966,4 +997,21 @@ abstract class ExchangeViewModelBase extends WalletChangeListenerViewModel with
return false;
}
}

double initialAmountByAssets (CryptoCurrency ticker) {
final amount = switch (ticker) {
CryptoCurrency.trx => 1000,
CryptoCurrency.nano => 10,
CryptoCurrency.zano => 10,
CryptoCurrency.wow => 1000,
CryptoCurrency.ada => 1000,
CryptoCurrency.dash => 10,
CryptoCurrency.rune => 10,

_ => 1
};
return amount.toDouble();
}


}
Loading