-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustments to the field set "usage" docs #1072
Comments
@ebeahan I'm not sure how to interpret
|
When a usage doc is added, it also adds another nested level under the field set it's associated with in the docs: The title of the usage doc will also be used as the name in the sidebar. If I wanted to hypothetically name my usage doc "Something Else" for the URL fieldset: [[ecs-url-usage]]
==== Something Else
... It would generate in the docs as: I think the intent here is to have the sidebar always use "Usage" for the usage docs links and not the title of the usage doc itself. |
OK, thanks for the extensive clarification @ebeahan, since it's already called I've taken a look through a sample of other Elastic docs to how we frame https://www.elastic.co/guide/en/elasticsearch/client/net-api/7.x/pipeline-aggregations.html https://www.elastic.co/guide/en/elasticsearch/reference/7.x/_api_usage.html During this (brief) search I couldn't find any examples of "Usage" as a single word title, the standard would appear to be more verbose titles, which may also be advantageous when locating content via the search box. So, I'm inclined to actually suggest the opposite - that the Also, I think the I'll submit the PR for the fixes to the callout from the |
@djptek I really like your suggested rename. And I think the mentioned tweaks to the page as a whole would be nice to help sharpen things up a bit. |
Thanks for the work in #1345! Let's keep this open until we finalize an approach with the sidebar. I've edited the original description showing we've completed two of three adjustments so far.
I like this more verbose naming as well. I do still see value in trying to ensure there's consistency in the sidebar. The way
Then include uses the section title from the usage doc page to generate the link in the sidebar: [[ecs-user-usage]]
==== Usage Maybe we do a quick investigation to see if anything AsciiDoc can do to ensure consistency, but I don't think it's something we invest much time into. I think it's an acceptable alternative to document our convention (say that we decide on If we do the latter, it'll just be an item we keep in mind when writing/reviewing feature usage doc contributions.
For these or any other possible improvements you come across, feel free to open an issue and/or PR so we can address them. |
this was trivial in I am not super-keen on the text I've opened a PR #1354 |
Here's a quick screenshot of how #1354 looks |
#1354 merged and closed |
Capturing thoughts while working on #1066.
The call out to the usage section -- under the field set description -- looks like just one more line in the normal description. We should make it stand out more. Example:
Currently:
Find additional usage and examples in the [field set shortname] fields usage section.
Suggested: TBD, in the context of making it stand out more.
Right now the sidebar link is based on the page heading.
I'd like to ensure the sidebar has a regular look, regardless of the heading we put on each page. We should override the sidebar link text to
<<...,Usage>>
.The text was updated successfully, but these errors were encountered: