Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to the field set "usage" docs #1345

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Adjustments to the field set "usage" docs #1345

merged 4 commits into from
Apr 13, 2021

Conversation

djptek
Copy link
Contributor

@djptek djptek commented Apr 7, 2021

See #1072

@djptek djptek marked this pull request as draft April 7, 2021 13:19
@djptek djptek marked this pull request as ready for review April 8, 2021 08:47
@djptek djptek requested review from ebeahan and kgeller April 8, 2021 08:47
ebeahan
ebeahan previously approved these changes Apr 8, 2021
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the changelog, otherwise LGTM

@djptek
Copy link
Contributor Author

djptek commented Apr 13, 2021

1 line change to CHANGELOG.next.md applied, all tests passed, merging

@djptek djptek merged commit 5b6bc6f into elastic:master Apr 13, 2021
djptek added a commit that referenced this pull request Apr 13, 2021
* moved call out to field set Usage docs
@djptek djptek deleted the adjust_field_set_usage_docs branch April 13, 2021 14:48
@ebeahan ebeahan added 1.10.0 and removed 1.x labels Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants