Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust field set usage docs sidebar links #1354

Merged
merged 8 commits into from
Apr 15, 2021
Merged

Adjust field set usage docs sidebar links #1354

merged 8 commits into from
Apr 15, 2021

Conversation

djptek
Copy link
Contributor

@djptek djptek commented Apr 13, 2021

  • Have you signed the contributor license agreement? Y
  • Have you followed the contributor guidelines? Y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? n/a
  • If submitting code/script changes, have you verified all tests pass locally using make test? Y
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? Y
  • Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. Y
  • Have you added an entry to the CHANGELOG.next.md? Y

Address #1072 (comment)

@djptek djptek requested review from ebeahan and kgeller April 13, 2021 17:56
kgeller
kgeller previously approved these changes Apr 13, 2021
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@djptek
Copy link
Contributor Author

djptek commented Apr 15, 2021

@ebeahan split lines are now (re-)concatenated

Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@djptek djptek merged commit a258b6e into elastic:master Apr 15, 2021
@djptek djptek deleted the adjust_field_set_usage_docs_sidebar_links branch April 15, 2021 15:38
djptek added a commit that referenced this pull request Apr 15, 2021
* Adjustments to the sidebar naming convention for usage and examples docs

Co-authored-by: Eric Beahan <[email protected]>
@ebeahan ebeahan added the 1.10.0 label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants