-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust field set usage docs sidebar links #1354
Merged
djptek
merged 8 commits into
elastic:master
from
djptek:adjust_field_set_usage_docs_sidebar_links
Apr 15, 2021
Merged
Adjust field set usage docs sidebar links #1354
djptek
merged 8 commits into
elastic:master
from
djptek:adjust_field_set_usage_docs_sidebar_links
Apr 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kgeller
previously approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ebeahan
reviewed
Apr 14, 2021
Co-authored-by: Eric Beahan <[email protected]>
…ithub.com/djptek/ecs into adjust_field_set_usage_docs_sidebar_links
@ebeahan split lines are now (re-)concatenated |
ebeahan
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
djptek
added a commit
that referenced
this pull request
Apr 15, 2021
* Adjustments to the sidebar naming convention for usage and examples docs Co-authored-by: Eric Beahan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test
? Ymake
and committed those changes? YAddress #1072 (comment)