-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Create Threat Fieldset - Stage 3 Proposal #1480
Conversation
updating fork
updating fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that more implementation work and testing has been done, do we have any resolution we can capture under Concerns
?
For # 1 under @rylnd or @dcode under |
|
@@ -291,6 +310,8 @@ Stage 1: Identify potential concerns, implementation challenges, or complexity. | |||
--> | |||
|
|||
1. How to best represent malware{name,family,type}. Current proposal is to use `threat.indicator.classification` to describe threat delivery (Hacktool etc.) and family name. | |||
- This can be represented through the use of the [`threat.software.*`](https://www.elastic.co/guide/en/ecs/master/ecs-threat.html) fields. | |||
- Awaiting [approval](https://github.com/elastic/ecs/pull/1480#issuecomment-889312434) of this recommendation. | |||
1. Field types (Ref: https://github.com/elastic/ecs/pull/1127#issuecomment-776126293) | |||
- `threatintel.indicator.*` (Filebeat module) will be normal field type and will be deprecated when nested field types are better supported in Kibana | |||
- `threat.indicator.*` (actual threat ECS fieldset) will be nested now and used for enriched doc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peasead I don't think this is still true; the plan for threat.indicator
is to keep it as a normal field, as is already the case with threatintel.indicator
. RE the migration below, I think the only change on the data shipper side is to rename threatintel.indicator
to threat.indicator
.
threat.enrichments
is the nested field that will cover the enrichment use case; the caveats about kibana support still apply there for Detection Alerts and users manually adopting the threat.enrichments
fields, but it should not impact data shippers at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I believe threat.enrichments
bypasses the nested support issue by allowing:
- Data shippers to generate normal
threat.indicator
fields - Enrichment mechanisms to populate nested
threat.enrichments
fields
Users wishing to ingest their own CTI data into indicator documents to be consumed within the detection engine can either:
- Populate normal
threatintel.indicator
fields, a la the current threatintel filebeat modules, as that is the current standard and the default for indicator match rules (for 7.14) - Populate normal
threat.indicator
fields, as that will be the default enrichment path for indicator match rules in 7.15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebeahan we're ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I identified a couple of small items, but otherwise LGTM.
@devonakerr Would you provide your final review here as sponsor? |
Co-authored-by: Eric Beahan <[email protected]>
We're ready for a final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, remarkable how far we've come with the schema in such a short period.
make test
? Yesmake
and committed those changes? YesStage 3 criteria:
Preview of markdown proposal doc