-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Threat Enrichment - Stage 3 #1581
Conversation
Note: no significant changes have yet been identified for this PR. We've adopted these beta fields in various CTI features as part of kibana's 7.15.0 release, and the current plan is to leave this open, acquire feedback from the 7.15 release, and then close stage 3 once we've determined 7.15 to be stable with regards to these fields. |
These fields should share a common reference that cannot be updated independently; however the tooling currently does not allow that.
@ebeahan @peasead I've updated the confidence field here to reflect the changes from #1480 (9343135). As I mention in the commit, it would be great if the tooling could support that automatically. @ebeahan should I file a feature request for something like that? I'm not really sure what it would take in terms of implementation, but I could certainly describe it from a user perspective. |
One small change that has been brought up in recent discussions: the ability to capture when an enrichment occurred, so as to view the most recent enrichments, audit enrichments, etc. To me this makes the most sense as a |
@rylnd I lean |
This offers consumers insight into when a given match happened, for purposes of auditing and observability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Ryland.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'll update the date here and get this merged, and get a PR up shortly for those implementation updates.
Setting the date for merge
Hi @ryland @devonakerr @kgeller @ebeahan I have a usage question regarding I'm working on an integration where some types of alerts have multiple indicators, and others don't. At some point I expect to build a dashboard based on a TERMS aggregation across the values that may be contained in both fields. To avoid run-time performance issues, I'd like to normalise the STIX indicators to a single field. Would it make sense to insert a nominal indicator and then populate I am inclined towards this approach since the |
What kind of Aggregations are you aiming to run with the |
@djptek I'm not aware of a If you're trying to reduce multiple values to a single one, the logic to do this sounds specific to your need. Just note that those indicators are nested documents, so your query/transformation would likely need to account for that. Hopefully this helps point you in the right direction; if not, getting more details about your problem/goals might be needed. |
Hi @rylnd
sorry, typo, I intended to refer to my concern is that the indicators (in my use case) are really separate events and encapsulating them all in a single event using an array:
Thanks to @andrewkroh for directing me to how to split an event into multiple events i.e. denormalise I wasn't aware that we'd (added?) that, it has been a long time ask elsewhere in the stack Did you consider the possibility of denormalising multiple indicators into separate events (with duplicate parent metadata) as an alternative to adding the |
make test
? Yesmake
and committed those changes? YesStage 3 criteria:
Preview of markdown proposal doc