Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent failure if no files need to be deleted find | xargs rm #1565

Closed
wants to merge 1 commit into from

Conversation

ypid-geberit
Copy link
Contributor

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

@ebeahan
Copy link
Member

ebeahan commented Aug 19, 2021

The Makefile rule that uses this command is going away in an upcoming version - see #1567.

However, we could still apply this fix to past/current 1.x branches.

@ypid-geberit
Copy link
Contributor Author

In that case, do as you see fit.

@ebeahan
Copy link
Member

ebeahan commented Aug 23, 2021

Cherry-picked this change to target 1.12 in #1588

@ebeahan ebeahan closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants