Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Go code generator #1567

Merged
merged 7 commits into from
Aug 19, 2021
Merged

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Aug 16, 2021

As discussed in #630 (comment), strip this functionality out of elastic/ecs with the 8.0 release to simplify the ECS repo's dependencies.

If producing this type of ECS-based Go package becomes necessary for or after ECS 8.0, we can explore creating a separate repo for that package.

This PR removes:

  • Go code generated based on ECS, located in code/go/ecs.
  • Go code that maintained those *.go files, located in scripts/cmd.
  • go.mod and go.sum located in scripts
  • Go code-related Makefile rules and targets
  • make setup from the GitHub Action workflow config.

@ebeahan ebeahan added the 8.0.0 label Aug 16, 2021
@ebeahan ebeahan self-assigned this Aug 16, 2021
@ebeahan ebeahan mentioned this pull request Aug 16, 2021
4 tasks
@ebeahan ebeahan marked this pull request as ready for review August 16, 2021 19:40
@ebeahan ebeahan requested a review from a team August 16, 2021 19:40
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants