Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash ordering fix #1603

Merged
merged 14 commits into from
Sep 16, 2021
Merged

Hash ordering fix #1603

merged 14 commits into from
Sep 16, 2021

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Sep 8, 2021

@P1llus realized we were missing hash.* under threat.indicator.file and `threat.enrichments.indicator.file' like the threat RFC describes. I realized this was due to an ordering issue on our field reuses. We solve this issue the same way here for 'group' at 'user'.

@kgeller kgeller mentioned this pull request Sep 9, 2021
Copy link
Contributor

@epixa epixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgeller kgeller merged commit e08d79d into elastic:master Sep 16, 2021
@kgeller kgeller deleted the hash-ordering-fix branch September 16, 2021 18:03
kgeller added a commit that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants