-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threat implementation reuse correction #1604
Conversation
@kgeller I think the deletions make sense, but I was also expecting to see the addition of hash fields to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deletions here LGTM! We have #1603 for the necessary additions, as well.
One related issue I noticed: we may have the same problem with the pe
fields, where those are typically nested under indicator.file
and not as top-level indicator.pe
fields, as the schema currently suggests. We can pick that up in another PR as needed, though.
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the debugging of another issue, I noticed a discrepancy in the implementation of an RFC.
Here under Hash, you'll see we intend to reuse under
file
andprocess
, but we implemented as reuse underthreat.indicator
.