Add type hints to schema modules #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgeller
approved these changes
May 3, 2022
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
May 5, 2022
* declare type hint classes for schema objects * first pass defining type hints * first pass applying type hints to cleaner * linting * adding hints to most helper functions * adding additional fields * changing to _ since not accessed * adding type hints to visit * adding type hints to exclude_filter * linting * add type hints to subset_filter * add type hints to loader * misc cleanup after mypy checks * moving types to dedicated module * fix import * unused import * convert to use f-string * misc cleanup from mypy checks * add changelog Co-authored-by: Kylie Geller <[email protected]> (cherry picked from commit a1bac19)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
ebeahan
added a commit
that referenced
this pull request
May 5, 2022
* declare type hint classes for schema objects * first pass defining type hints * first pass applying type hints to cleaner * linting * adding hints to most helper functions * adding additional fields * changing to _ since not accessed * adding type hints to visit * adding type hints to exclude_filter * linting * add type hints to subset_filter * add type hints to loader * misc cleanup after mypy checks * moving types to dedicated module * fix import * unused import * convert to use f-string * misc cleanup from mypy checks * add changelog Co-authored-by: Kylie Geller <[email protected]> (cherry picked from commit a1bac19)
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
May 16, 2022
* declare type hint classes for schema objects * first pass defining type hints * first pass applying type hints to cleaner * linting * adding hints to most helper functions * adding additional fields * changing to _ since not accessed * adding type hints to visit * adding type hints to exclude_filter * linting * add type hints to subset_filter * add type hints to loader * misc cleanup after mypy checks * moving types to dedicated module * fix import * unused import * convert to use f-string * misc cleanup from mypy checks * add changelog Co-authored-by: Kylie Geller <[email protected]> (cherry picked from commit a1bac19) # Conflicts: # CHANGELOG.next.md
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
ebeahan
added a commit
that referenced
this pull request
May 16, 2022
* declare type hint classes for schema objects * first pass defining type hints * first pass applying type hints to cleaner * linting * adding hints to most helper functions * adding additional fields * changing to _ since not accessed * adding type hints to visit * adding type hints to exclude_filter * linting * add type hints to subset_filter * add type hints to loader * misc cleanup after mypy checks * moving types to dedicated module * fix import * unused import * convert to use f-string * misc cleanup from mypy checks * add changelog Co-authored-by: Kylie Geller <[email protected]> (cherry picked from commit a1bac19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradually adding typing to the existing code base with two end goals:
No functional changes.