Add type annotations to scripts.generator modules
#1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Jun 16, 2022
* add type hints to csv_generator * introduce csv generator unit tests * finish adding types to intermediate generator * returns a tuple * add type hints to beats generator * unused import * add type hints to elasticsearch generator * use snake_case * changelog (cherry picked from commit 25ec625) # Conflicts: # CHANGELOG.next.md
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
ebeahan
added a commit
that referenced
this pull request
Jun 16, 2022
* add type hints to csv_generator * introduce csv generator unit tests * finish adding types to intermediate generator * returns a tuple * add type hints to beats generator * unused import * add type hints to elasticsearch generator * use snake_case * changelog (cherry picked from commit 25ec625)
mitodrummer
pushed a commit
to mitodrummer/ecs
that referenced
this pull request
Jul 6, 2022
* add type hints to csv_generator * introduce csv generator unit tests * finish adding types to intermediate generator * returns a tuple * add type hints to beats generator * unused import * add type hints to elasticsearch generator * use snake_case * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Continue the work in #1771 to gradually introduce type hints into the codebase.
Summary of changes
scripts/generatorscsv_generatorschema.subset_filterto note aTuple.