Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.4] Add type annotations to scripts.generator modules (#1950) #1960

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Jun 16, 2022

Backport

This will backport the following commits from main to 8.4:

Questions ?

Please refer to the Backport tool documentation

* add type hints to csv_generator

* introduce csv generator unit tests

* finish adding types to intermediate generator

* returns a tuple

* add type hints to beats generator

* unused import

* add type hints to elasticsearch generator

* use snake_case

* changelog

(cherry picked from commit 25ec625)

# Conflicts:
#	CHANGELOG.next.md
@ebeahan ebeahan requested a review from a team as a code owner June 16, 2022 16:34
@ebeahan ebeahan merged commit 6cebb41 into elastic:8.4 Jun 16, 2022
@ebeahan ebeahan deleted the backport/8.4/pr-1950 branch June 16, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant