Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ios and android as valid values for os.type #1999

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

AlexanderWert
Copy link
Member

Closes #1995

Adds ios and android as valid values for the os.type field to support mobile use cases (E.g. APM / distributed tracing in mobile devices).

/cc @simitt, @felixbarny

@AlexanderWert AlexanderWert requested a review from kgeller July 26, 2022 15:27
@AlexanderWert AlexanderWert requested a review from a team as a code owner July 26, 2022 15:27
@djptek
Copy link
Contributor

djptek commented Jul 26, 2022

@AlexanderWert Please can you run make check locally to generate the artefacts & then check those in to advance the unit tests

Copy link
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexanderWert AlexanderWert merged commit bf11ece into elastic:main Jul 27, 2022
This was referenced Jul 28, 2022
kgeller pushed a commit to kgeller/ecs that referenced this pull request Jul 28, 2022
* Added ios and android as valid values for os.type

* Generated files based on os.type change
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping OS fields for mobile devices (e.g. Android, iOS)
3 participants