Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Faas fields - stage 2 - change faas.trigger type from nested to object #2194

Merged
merged 6 commits into from
Apr 28, 2023
Merged

[RFC] Faas fields - stage 2 - change faas.trigger type from nested to object #2194

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e18d4e0
change faas.trigger type from nested to object
gsantoro Apr 6, 2023
9b0c331
removed faas.trigger altogether
gsantoro Apr 11, 2023
faf5b12
Merge branch 'main' into faas-stage-2.1
gsantoro Apr 11, 2023
d01feb8
Merge branch 'main' into faas-stage-2.1
gsantoro Apr 13, 2023
a049970
added changelog
gsantoro Apr 13, 2023
cc1a07c
Merge remote-tracking branch 'origin/main' into faas-stage-2.1
felixbarny Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/fields/field-details.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3938,7 +3938,7 @@ example: `my-function`

a| Details about the function trigger.

type: nested
type: object



Expand Down
2 changes: 1 addition & 1 deletion experimental/generated/beats/fields.ecs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2699,7 +2699,7 @@
default_field: false
- name: trigger
level: extended
type: nested
type: object
description: Details about the function trigger.
default_field: false
- name: trigger.request_id
Expand Down
2 changes: 1 addition & 1 deletion experimental/generated/csv/fields.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
8.8.0-dev+exp,true,faas,faas.execution,keyword,extended,,af9d5aa4-a685-4c5f-a22b-444f80b3cc28,The execution ID of the current function execution.
8.8.0-dev+exp,true,faas,faas.id,keyword,extended,,arn:aws:lambda:us-west-2:123456789012:function:my-function,The unique identifier of a serverless function.
8.8.0-dev+exp,true,faas,faas.name,keyword,extended,,my-function,The name of a serverless function.
8.8.0-dev+exp,true,faas,faas.trigger,nested,extended,,,Details about the function trigger.
8.8.0-dev+exp,true,faas,faas.trigger,object,extended,,,Details about the function trigger.
8.8.0-dev+exp,true,faas,faas.trigger.request_id,keyword,extended,,123456789,"The ID of the trigger request , message, event, etc."
8.8.0-dev+exp,true,faas,faas.trigger.type,keyword,extended,,http,The trigger for the function execution.
8.8.0-dev+exp,true,faas,faas.version,keyword,extended,,123,The version of a serverless function.
Expand Down
2 changes: 1 addition & 1 deletion experimental/generated/ecs/ecs_flat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3786,7 +3786,7 @@ faas.trigger:
name: trigger
normalize: []
short: Details about the function trigger.
type: nested
type: object
faas.trigger.request_id:
dashed_name: faas-trigger-request-id
description: The ID of the trigger request , message, event, etc.
Expand Down
2 changes: 1 addition & 1 deletion experimental/generated/ecs/ecs_nested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4805,7 +4805,7 @@ faas:
name: trigger
normalize: []
short: Details about the function trigger.
type: nested
type: object
faas.trigger.request_id:
dashed_name: faas-trigger-request-id
description: The ID of the trigger request , message, event, etc.
Expand Down
2 changes: 1 addition & 1 deletion experimental/generated/elasticsearch/composable/component/faas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"type": "keyword"
}
},
"type": "nested"
"type": "object"
},
"version": {
"ignore_above": 1024,
Expand Down
2 changes: 1 addition & 1 deletion experimental/generated/elasticsearch/legacy/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,7 @@
"type": "keyword"
}
},
"type": "nested"
"type": "object"
},
"version": {
"ignore_above": 1024,
Expand Down
2 changes: 1 addition & 1 deletion generated/beats/fields.ecs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2649,7 +2649,7 @@
default_field: false
- name: trigger
level: extended
type: nested
type: object
description: Details about the function trigger.
default_field: false
- name: trigger.request_id
Expand Down
2 changes: 1 addition & 1 deletion generated/csv/fields.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
8.8.0-dev,true,faas,faas.execution,keyword,extended,,af9d5aa4-a685-4c5f-a22b-444f80b3cc28,The execution ID of the current function execution.
8.8.0-dev,true,faas,faas.id,keyword,extended,,arn:aws:lambda:us-west-2:123456789012:function:my-function,The unique identifier of a serverless function.
8.8.0-dev,true,faas,faas.name,keyword,extended,,my-function,The name of a serverless function.
8.8.0-dev,true,faas,faas.trigger,nested,extended,,,Details about the function trigger.
8.8.0-dev,true,faas,faas.trigger,object,extended,,,Details about the function trigger.
8.8.0-dev,true,faas,faas.trigger.request_id,keyword,extended,,123456789,"The ID of the trigger request , message, event, etc."
8.8.0-dev,true,faas,faas.trigger.type,keyword,extended,,http,The trigger for the function execution.
8.8.0-dev,true,faas,faas.version,keyword,extended,,123,The version of a serverless function.
Expand Down
2 changes: 1 addition & 1 deletion generated/ecs/ecs_flat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3717,7 +3717,7 @@ faas.trigger:
name: trigger
normalize: []
short: Details about the function trigger.
type: nested
type: object
faas.trigger.request_id:
dashed_name: faas-trigger-request-id
description: The ID of the trigger request , message, event, etc.
Expand Down
2 changes: 1 addition & 1 deletion generated/ecs/ecs_nested.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4725,7 +4725,7 @@ faas:
name: trigger
normalize: []
short: Details about the function trigger.
type: nested
type: object
faas.trigger.request_id:
dashed_name: faas-trigger-request-id
description: The ID of the trigger request , message, event, etc.
Expand Down
2 changes: 1 addition & 1 deletion generated/elasticsearch/composable/component/faas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"type": "keyword"
}
},
"type": "nested"
"type": "object"
},
"version": {
"ignore_above": 1024,
Expand Down
2 changes: 1 addition & 1 deletion generated/elasticsearch/legacy/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,7 +1286,7 @@
"type": "keyword"
}
},
"type": "nested"
"type": "object"
},
"version": {
"ignore_above": 1024,
Expand Down
2 changes: 1 addition & 1 deletion schemas/faas.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
example: "af9d5aa4-a685-4c5f-a22b-444f80b3cc28"
- name: trigger
level: extended
type: nested
type: object
description: >
Details about the function trigger.
- name: trigger.type
Expand Down