-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ECS doc from MD to asciidoc guide: initial setup #266
Conversation
@karenzone Would it make sense to get this in master rather soonish so we could start to play around with the docs builds? Or can we do this also when it's in a branch? |
What is there so far is in decent shape. It builds without error. There's more I want to do, but moving v1 into Master wouldn't prevent that. I'm good with move to master if you are. Thanks for taking time to look at this. |
Now that we branched out 1.0 this can go into master. What are the commands you run the build the docs? I'm thinking of adding a |
It requires the elastic/docs repo. I build it locally using |
Just opened #275 so we can have an automated docs build in the future. @karenzone Happy to get yours in first and then rebase mine on top. The firebase link you posted is also very useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume so far it's mostly copy/paste of the existing content and no major changes happened?
@ruflin Some reformatting required. For example:
|
Sounds like no content changes to me then. I'm ok with merging. |
* ECS doc conversion from md to asciidoc * Add back uc-header file * New asciidoc files
Convert ECS readme.md file to asciidoc to be published at https://www.elastic.co/guide/index.html.
https://ecs-simple.firebaseapp.com/
Issue #276 opened to track additional steps