-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automation around docs generation #275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an almost empty `index.asciidoc` file to generate the initial asciidoc version of the docs. With this `make docs` can be used to generate and preview the docs.
a2d42ac
to
8b1e0d8
Compare
webmat
approved these changes
Dec 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@karenzone From now on all docs PR will also be tested to check if they are valid. |
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Mar 5, 2019
This adds an almost empty `index.asciidoc` file to generate the initial asciidoc version of the docs. With this `make docs` can be used to generate and preview the docs.
webmat
added a commit
that referenced
this pull request
Mar 6, 2019
) Backport of PR #275 to 1.0 branch. Original message: This adds an almost empty `index.asciidoc` file to generate the initial asciidoc version of the docs. With this `make docs` can be used to generate and preview the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an almost empty
index.asciidoc
file to generate the initial asciidoc version of the docs. With thismake docs
can be used to generate and preview the docs.This allows us to also validate the docs build in CI.