Added url.extension field #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a url extension field as using the file.extension field to store this could confuse security analysts. It should be easier for security analysts to associate extension and url if it's in the url object. We want to avoid them thinking the file exists on the computer.
|
@elasticmachine, run elasticsearch-ci/docs |
webmat
suggested changes
Sep 23, 2019
| short: File extension from the original request url. | ||
| description: > | ||
| The field contains the file extension from the original request url. | ||
| The file extension is only set if it exists, as not every url has a file extension. |
There was a problem hiding this comment.
Please insert an additional blank line here, to have this as two paragraphs in the docs
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Oct 1, 2019
Also add en example
Merged
|
@mbudge I just realized that how I've finished up the work on your contributions #542 and #557 didn't have you appear in the commits, as we squash the commits when merging PRs. Sorry about that. I'll change my approach and merge your PRs, then rebase mine on top, in order for you to show up in the credits. Your input was really appreciated, and I think it's important to preserve that in the history, and repo stats 🙂 |
webmat
pushed a commit
that referenced
this pull request
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a url extension field as using the file.extension field to store this could confuse security analysts. It should be easier for security analysts to associate extension and url if it's in the url object. We want to avoid them thinking the file exists on the computer straight away.
Proxy logs provide the file extension in a uri extension field, along with
uri schema
uri domain
uri query
uri path etc..
Security analysts will want to look for file types like exe, js, swf, hda, vb, vbs, jar, bat coming from suspicious sites/locations.