-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added location and name field to observer. #557
Conversation
Web proxies can block traffic in the same way as an IPS. Added a location and name field so observer can hold these fields which are found in web proxy logs.
@mbudge Indeed a proxy would be considered an observer in ECS. In fact, it is listed as one of the examples for the Please note that the geo.* fields maybe nested below In addition, ECS specifies For example: you might have: So I think we already have enough observer fields to capture this information, so I don't think we should proceed with your proposed Thanks! |
Hi, Didn't see the observer.os.location so we'll use that. Not sure about observer.os.name for the appliance name, as we want to store the appliances custom name used to identify the appliance. This is similar to the agent.name field but for appliances instead of an agent. There could be several if there are multiple web proxies on the network. Thanks! |
@mbudge Good point about the actual name of the observer in addition to its location. Also, I think my above use of
and another:
If you agree that these are good mappings, then if you would modify this PR to include only the Thanks for your active contributions! |
The product field is for the observer product name. The name field is for the observers custom name.
Agreed those fields would be a great addition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this over, this looks good! It will make the observer
field set that much more aligned with agent
:-)
I have a few small requests before we merge this in, please:
- Add a changelog entry to
CHANGELOG.next.md
- Adjust the descriptions for
.name
and.product
as described in the comments below - Add the corresponding example to
.vendor
, so we have "Symantec s200" broken out to their appropriate fields, in their respective examples
Thanks again!
level: core | ||
type: keyword | ||
description: > | ||
Name of the observer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please flesh out this description a little more, to make it clear that this is meant to be user-configured.
For inspiration, here's two other places in ECS where we have .name
meant to be a user-customizable value: agent.name and host.name
level: core | ||
type: keyword | ||
description: > | ||
The observers product name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency's sake with the other field definitions, please use
The observers product name. | |
The product name of the observer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another request, since we're going with @MikePaquette's s200 example, could you also add a corresponding example to the "vendor" field, with value "Symantec", please?
@@ -31,6 +31,18 @@ | |||
type: keyword | |||
description: > | |||
Hostname of the observer. | |||
- name: name | |||
level: core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make these fields extended for now? Easy to move it to core later but not sure about the other way around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for level: extended
for these new additions
@@ -31,6 +31,18 @@ | |||
type: keyword | |||
description: > | |||
Hostname of the observer. | |||
- name: name | |||
level: core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for level: extended
for these new additions
Web proxies can block traffic in the same way as an Intrusion Prevention System which is listed as a type of Observer. Added a location and name field so observer can also store fields use to describe web proxy appliances found in web proxy logs.