Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observer.name and observer.product #571

Merged
merged 7 commits into from
Oct 3, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Oct 1, 2019

This PR is meant to finalize the work on #557 by applying the feedback in time
for ECS 1.2.0. Thanks for getting this started, @mbudge!

Closes #557

mbudge and others added 5 commits September 11, 2019 23:18
Web proxies can block traffic in the same way as an IPS. Added a location and name field so observer can hold these fields which are found in web proxy logs.
The product field is for the observer product name. The name field is for the observers custom name.
@webmat webmat self-assigned this Oct 1, 2019
@webmat webmat added the 1.2.0 label Oct 1, 2019
Copy link
Contributor

@MikePaquette MikePaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmat webmat merged commit 204d4de into elastic:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants