Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some ATT&CK verbiage and trademark #866

Merged
merged 5 commits into from
Jun 9, 2020
Merged

Fix some ATT&CK verbiage and trademark #866

merged 5 commits into from
Jun 9, 2020

Conversation

rw-access
Copy link
Contributor

I saw some verbiage for threat.* that mentioned the MITRE ATT&CK® framework but needed to be adjusted.

Some of the changes

  • Added ®. We were supposed to have ™ before, but early in 2020 they were granted ®.
  • Correctly spelled MITRE with all capital letters
  • Removed some confusing verbiage like "You can use the Mitre ATT&CK Matrix Tactic categorization." The words "Tactic categorization" are a little confusing and not part of the framework. Instead I went with "You can use a MITRE ATT&CK Matrix® tactic, for example." Also, it's possible to mention tactics without concrete techniques and vice versa, so I removed any language that coupled them together.

@rw-access rw-access requested a review from webmat June 8, 2020 16:51
@rw-access rw-access changed the title Fix some MITRE verbiage and trademark Fix some ATT&CK verbiage and trademark Jun 8, 2020
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, @rw-access!

One small nitpick, see comment below. Otherwise LGTM :-)

@@ -29,8 +29,8 @@
type: keyword
short: Threat tactic.
description: >
Name of the type of tactic used by this threat. You can use the Mitre ATT&CK Matrix Tactic categorization, for example.
(ex. https://attack.mitre.org/tactics/TA0040/ )
Name of the type of tactic used by this threat. You can use the MITRE ATT&CK® Matrix tactic categorization, for example.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would switch the phrasing "use a" instead of "use the" for this sentence as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! this is why we peer review 😆

@rw-access rw-access merged commit cfc53cb into elastic:master Jun 9, 2020
@rw-access rw-access deleted the mitre-fix branch June 9, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants