Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Add I/O timeouts #88

Closed
foxcpp opened this issue Feb 16, 2020 · 3 comments · Fixed by #115
Closed

client: Add I/O timeouts #88

foxcpp opened this issue Feb 16, 2020 · 3 comments · Fixed by #115
Labels
enhancement

Comments

@foxcpp
Copy link
Collaborator

foxcpp commented Feb 16, 2020

RFC 5321:

4.5.3.2. Timeouts

An SMTP client MUST provide a timeout mechanism. It MUST use per-
command timeouts rather than somehow trying to time the entire mail
transaction. Timeouts SHOULD be easily reconfigurable, preferably
without recompiling the SMTP code.
@emersion
Copy link
Owner

We probably want to set some sane defaults.

@foxcpp
Copy link
Collaborator Author

foxcpp commented Feb 17, 2020

RFC 5321 provides recommended minimal timeouts

@foxcpp foxcpp mentioned this issue Jun 12, 2020
Closed
6 tasks
@foxcpp
Copy link
Collaborator Author

foxcpp commented Jul 17, 2020

I wonder if this could be implemented by adding context.Context support for client (#19).

@foxcpp foxcpp mentioned this issue Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: Implement command timeouts foxcpp/go-smtp
2 participants
@emersion @foxcpp