Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper timeouts for SMTP client #239

Closed
5 of 6 tasks
foxcpp opened this issue Jun 12, 2020 · 2 comments
Closed
5 of 6 tasks

Implement proper timeouts for SMTP client #239

foxcpp opened this issue Jun 12, 2020 · 2 comments
Assignees
@foxcpp
Labels
good first issue Easy to do, good for newcomers. mta-out Related to MSA or outgoing message processing part of MTA functionality. ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele
Milestone
0.5

Comments

@foxcpp
Copy link
Owner

foxcpp commented Jun 12, 2020 •
edited
Loading

Meta-issue. maddy needs configuration options and such when emersion/go-smtp#88 gets implemented.

Checklist:

  • TCP connection timeout (including DNS lookup)
  • TLS handshake timeout (implicit TLS)
  • TLS handshake timeout (STARTTLS)
  • Command timeout
  • Message I/O timeout
  • "Final dot" timeout
@foxcpp foxcpp added mta-out Related to MSA or outgoing message processing part of MTA functionality. good first issue Easy to do, good for newcomers. labels Jun 12, 2020
@foxcpp foxcpp added this to the 0.4 milestone Jun 12, 2020
@foxcpp foxcpp modified the milestones: 0.4, 0.5 Aug 23, 2020
@foxcpp
Copy link
Owner Author

foxcpp commented Sep 13, 2020 •
edited
Loading

Corresponding go-smtp PR is merged, now to make that configurable in maddy.

@foxcpp
Copy link
Owner Author

foxcpp commented Jul 5, 2021

Ref. emersion/go-smtp#143

foxcpp added a commit that referenced this issue Jul 5, 2021
@foxcpp
Implement client timeouts for target.remote and target.smtp
cbd3870 
Closes #239.
@foxcpp foxcpp self-assigned this Jul 5, 2021
@foxcpp foxcpp added the ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele label Jul 10, 2021
@foxcpp foxcpp closed this as completed in d0487d7 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@foxcpp foxcpp

Labels
good first issue Easy to do, good for newcomers. mta-out Related to MSA or outgoing message processing part of MTA functionality. ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@foxcpp