-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: Implement command timeouts #115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 62.09% 62.46% +0.37%
==========================================
Files 8 8
Lines 1108 1119 +11
==========================================
+ Hits 688 699 +11
Misses 312 312
Partials 108 108
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also write a simple test with a stub server to simulate the timeout.
Any updates on this PR? |
I have a lot of IRL things to do. Feel free to finish this PR if you're interested. |
f180265
to
53d2f49
Compare
I renamed DotTimeout into SubmissionTimeout and also rebased PR onto upstream master so tests could run (there is new vet rule in Go 1.15 that failed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Closes #88.