Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Implement command timeouts #115

Merged
merged 1 commit into from
Sep 13, 2020
Merged

Conversation

foxcpp
Copy link
Collaborator

@foxcpp foxcpp commented Jul 17, 2020

Closes #88.

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #115 into master will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   62.09%   62.46%   +0.37%     
==========================================
  Files           8        8              
  Lines        1108     1119      +11     
==========================================
+ Hits          688      699      +11     
  Misses        312      312              
  Partials      108      108              
Impacted Files Coverage Δ
client.go 67.70% <100.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1918b06...f180265. Read the comment docs.

Copy link

@corny corny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also write a simple test with a stub server to simulate the timeout.

@kayrus
Copy link
Contributor

kayrus commented Sep 5, 2020

Any updates on this PR?

@foxcpp
Copy link
Collaborator Author

foxcpp commented Sep 6, 2020

Any updates on this PR?

I have a lot of IRL things to do. Feel free to finish this PR if you're interested.

@foxcpp
Copy link
Collaborator Author

foxcpp commented Sep 13, 2020

I renamed DotTimeout into SubmissionTimeout and also rebased PR onto upstream master so tests could run (there is new vet rule in Go 1.15 that failed)

Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@emersion emersion merged commit c20b441 into emersion:master Sep 13, 2020
@foxcpp foxcpp deleted the client-timeouts branch September 13, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client: Add I/O timeouts
4 participants