Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Add initial greeting timeout to NewClient #143

Merged
merged 1 commit into from
Jul 5, 2021
Merged

client: Add initial greeting timeout to NewClient #143

merged 1 commit into from
Jul 5, 2021

Conversation

foxcpp
Copy link
Collaborator

@foxcpp foxcpp commented Jul 5, 2021

No description provided.

@foxcpp foxcpp requested a review from emersion July 5, 2021 15:47
@foxcpp foxcpp mentioned this pull request Jul 5, 2021
Closed
6 tasks
emersion
emersion approved these changes Jul 5, 2021
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: previously users could set a timeout then call NewClient, but now they can't anymore. Not that I think anybody was doing that TBH. If anyone wants to customize the timeouts, they could introduce a new ClientOptions struct.

Thanks!

@emersion emersion merged commit 26eb481 into emersion:master Jul 5, 2021
@foxcpp foxcpp deleted the newclient-timeout branch July 5, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foxcpp @emersion