Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

110 Over- and underpasses (aka. level-free diamond crossings). #120

Merged
merged 14 commits into from
Mar 5, 2025
Merged

110 Over- and underpasses (aka. level-free diamond crossings). #120

merged 14 commits into from
Mar 5, 2025

Conversation

chenkins
Copy link
Contributor

@chenkins chenkins commented Feb 17, 2025 •
edited
Loading

Changes

  • Add list of cells which allow for level-free crossings if agents move in opposite directions.
  • Add p_level_free in rail gen to sample percentage of level free diamond-crossings from generated diamond crossings.

Related issues

Closes #110

Checklist

  • Tests are included for relevant behavior changes.
  • Documentation is added in the flatland-book repo for relevant behavior changes.
  • If you made important user-facing changes, describe them under the [Unreleased] tag in CHANGELOG.md.
  • New package dependencies are declared in the pyproject.toml file.
    Requirement files have been updated by running tox -e requirements.
  • Code works with all supported Python versions (3.10, 3.11 and 3.12). Checks run with all three version and are
    required to run successfully.
  • Code is formatted according to PEP 8 (an IDE like PyCharm can do this for you).
  • Technical guidelines listed in CONTRIBUTING.md are followed.

@chenkins chenkins force-pushed the 110-over-and-underpasses branch 2 times, most recently from d56bf68 to b8a63cd Compare February 17, 2025 13:34
@chenkins chenkins added this to the 4.0.5 milestone Feb 17, 2025
@chenkins chenkins changed the title 110 over- and underpasses 110 Over- and underpasses (aka. level-free diamond crossings). Feb 18, 2025
chenkins
chenkins commented Feb 19, 2025
View reviewed changes
@chenkins chenkins force-pushed the 110-over-and-underpasses branch from 429836c to 1a7202d Compare February 21, 2025 18:24
@chenkins chenkins marked this pull request as ready for review February 21, 2025 20:34
@chenkins chenkins requested a review from a team as a code owner February 21, 2025 20:34
@chenkins chenkins assigned manuschn and unassigned manuschn Feb 21, 2025
manuschn
manuschn approved these changes Mar 5, 2025
View reviewed changes
@chenkins chenkins mentioned this pull request Mar 5, 2025
Open
7 tasks
@chenkins chenkins force-pushed the 110-over-and-underpasses branch 2 times, most recently from e82b64d to 3d9f01e Compare March 5, 2025 14:56
@chenkins
Cleanup.
07d3384 
Signed-off-by: chenkins <[email protected]>
@chenkins chenkins force-pushed the 110-over-and-underpasses branch from 3d9f01e to 07d3384 Compare March 5, 2025 17:09
@chenkins chenkins enabled auto-merge (squash) March 5, 2025 19:18
@chenkins chenkins merged commit 7ef78f2 into main Mar 5, 2025
11 checks passed
@chenkins chenkins deleted the 110-over-and-underpasses branch March 5, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiAdrian aiAdrian aiAdrian approved these changes

@manuschn manuschn manuschn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.5
Development

Successfully merging this pull request may close these issues.

Over- and underpasses.
3 participants
@chenkins @aiAdrian @manuschn