Fix relURL with leading slash when baseURL includes a subdirectory #10002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravis
reviewed
Jun 22, 2022
| func (p *PathSpec) getBaseURLRoot(path string) string { | ||
| if strings.HasPrefix(path, "/") { | ||
| // Treat it as relative to the server root. | ||
| return p.BaseURLNoPathString |
There was a problem hiding this comment.
This looks like a regression to me. p.BaseURLNoPathString is not the p.BaseURL we used to return, therefore the path is stripped here. relURL in turn will output an invalid path, which doesn't contain the path (/foo in helpers/pathspec_test.go)
2 tasks
jmooring
added a commit
to gohugoio/hugoDocs
that referenced
this pull request
Nov 17, 2022
This addresses changes made in: gohugoio/hugo#10002 Closes #469
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9994